Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Jammy #1923

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Switching to Jammy #1923

merged 3 commits into from
Nov 10, 2023

Conversation

diemol
Copy link
Member

@diemol diemol commented Aug 23, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Member Author

diemol commented Aug 24, 2023

Firefox tests are failing because the current way of installing Firefox is not working on 22.04. Firefox is a snap package in Ubuntu 22.04, and we need to figure out how to remove it, install the deb package, use the snap package, and allow beta/dev versions to be installed.

@amardeep2006
Copy link
Contributor

amardeep2006 commented Oct 30, 2023

@diemol I just came across this Article to install Nightly.

https://www.omgubuntu.co.uk/2023/10/firefox-nightly-deb-packages-mozilla-apt-repostiory

https://blog.nightly.mozilla.org/2023/10/30/introducing-mozillas-firefox-nightly-deb-packages-for-debian-based-linux-distributions/

Does this means they have plans to do the same for other channels as well ? Or may be I am interpreting it too much ??
image

@diemol
Copy link
Member Author

diemol commented Nov 6, 2023

@diemol I just came across this Article to install Nightly.

https://www.omgubuntu.co.uk/2023/10/firefox-nightly-deb-packages-mozilla-apt-repostiory

https://blog.nightly.mozilla.org/2023/10/30/introducing-mozillas-firefox-nightly-deb-packages-for-debian-based-linux-distributions/

Does this means they have plans to do the same for other channels as well ? Or may be I am interpreting it too much ?? image

Seems so. The problem is that Firefox comes installed as a snap package in Jammy, so we also need a way to "remove" that binary before installing the one we want.

@VietND96
Copy link
Member

VietND96 commented Nov 10, 2023

I tried to troubleshoot and saw there are 2 errors in the Firefox node when starting Firefox browser

XPCOMGlueLoad error for file /opt/firefox-latest/libmozgtk.so:
libgtk-3.so.0: cannot open shared object file: No such file or directory
Couldn't load
XPCOMGlueLoad error for file /opt/firefox-119.0.1/libxul.so:
libdbus-glib-1.so.2: cannot open shared object file: No such file or directory
Couldn't load XPCOM

I have updated Dockerfile to apt-get install these 2 packages libgtk-3-dev, libdbus-glib-1-dev
All tests could be seen passed in the workflow https://github.com/ndviet/docker-selenium/actions/runs/6820672426
The update comes to feature branch via #2001

@diemol
Copy link
Member Author

diemol commented Nov 10, 2023

Thanks for your help @VietND96!

@diemol diemol merged commit f5f90dd into trunk Nov 10, 2023
5 checks passed
@diemol diemol deleted the ubuntu-jammy branch November 10, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants